Several tracks highlighted in Playlist Editor

[bflorat]

For all playlists but queue one, in playlist editor: normaly, current played track is highlighted in orange. If a playlist contains a file more than one, all of them will be highlighted and not only current one.

[fsck222]

(trac cleaning process) Is it a ticket still valid? if yes what version does it affect?

[varun]

This ticket is still valid. I can reproduce this. It happens when the current audio file being played appears more than once in the "Queue" Playlist, then all the files are highlighted. I guess a simple fix would be to just highlight the currently playing track.

[varun]

I have applied a fix in trunk. Please check if this fix is okay. I guess it could be bit confusing in playlists other than "queue" where if you have duplicate files in the playlist and if you are playling the second duplicate file, my fix will only highlight the first matching file. So, if this fix is acceptable, I shall backport it to 1.5 branch.

[bflorat]

No, we prefer to avoid any non-mandatory change in 1.5 branch.

On your fix: * I think that there's no problem on highlight several lines with the current playing item in non queue playlist. It appaers logical to me * You fix brings a new bug : if you launch a list containing tracks {t1,t2,t1} that you play in repeat mode, when FIFO played the second t1, it's the first line that will be highlighted. * On the performance side, it's less than optimal : to refresh table, the EDT will call n^{2 calls to isItemHighlighted() methods (that contains get on FIFO arraylist) when before you made only n calls for each screen refresh. I think that i can cause high CPU consumption for large playlists or tables.}

So I suggest to reverse your fix in the mean time if you don't mind. I for one still don't see any fix to this :-( and given the critical performance aspect of this code, there're perhaps no way to fix it without degrading performances.

[varun]

I agree. I have reversed my fix.

[bflorat]

Thanks

[fsck222]

do we need to keep to ticket open?

[bflorat]

Yes, it is not fixed and is a known limitation without known way to fix it.

[Sesamstrasse]

This is now fixed in trunk, see my ticket 1319. :)

I also kept the behavior for the playlist table and changed the highlighter only to the queue view.