Notice: Comments you submit will be routed for moderation. If you have an account, please log in first.

Ticket #1704 (closed Bug: fixed)

Opened 18 months ago

Last modified 18 months ago

wrong systray text

Reported by: goesen Owned by:
Priority: 5, normal Milestone: 1.9 "Killer Queen"
Component: User Interface Version: 1.9RC6
Keywords: Cc:

Description

1. Play a track with jajuk 2. pause or stop it 3. press previous or next track 4. check systray: it shows "pause" icon, but "resume" text

Attachments

more1.jpeg (24.0 kB) - added by goesen 18 months ago.
a screenshot
PlayerStateMediator.java (11.6 kB) - added by goesen 18 months ago.
The solution

Change History

Changed 18 months ago by goesen

a screenshot

Changed 18 months ago by itoijala

This is a duplicate of #1476 that I reported some time ago, but we never figured out how to reproduce it.

Changed 18 months ago by bflorat

  • priority changed from 1, lowest to 5, normal

I wasn't able to reproduce neither but reading the code, I figured out that if jajuk was stopped, it should behave like you described (but didn't by me for some reasons). However, my fix only affect the resume on stop, not the resume on pause so I'm not sure it's actually fixed for you.

Please try the 20 aug daily build at http://integration.jajuk.info/hudson/job/Jajuk%20Daily%20Build%20-%20Trunk/

Changed 18 months ago by goesen

I retried using your build: it does not fix the bug. Maybe you have misunderstood me: I haven' "resumed" the track, I choosed "previous track"

I discovered different ways to reproduce the bug: stop or pause jajuk and choose "play random track" or stop jajuk and click on some track shown in jajuk.

But if i click on "resume" everything works properly.

Maybe it's Linux related? I am using Kubuntu 64bit

Changed 18 months ago by goesen

The solution

Changed 18 months ago by goesen

I did some debugging:

There are two classes changing the name and the icon of "PlayPauseAction?" One is "PlayPauseAction?" itself and the other is "PlayerStateMediator?". "PlayerStateMediator?" starts from another Thread and passes it's modifications over to "SwingUtilities?.invokeLater". So there is no reason to modify icon and text in "PlayPauseAction?" when there is a queue : "PlayerStateMediator?" will overwrite changes.

There are 7 different situations where "PlayerStateMediator?" changes the icon of "PlayPauseAction?". But only on one occurance it does change the text too.

I have attached a modified Version of "PlayerStateMediator?". As far as i have tested it, it does fix the issue.

Changed 18 months ago by bflorat

  • status changed from new to closed
  • resolution set to fixed

You're absolutely right, thanks for the patch, it has been applied. As you suggested, I also cleaned-up PlayPauseAction? class and it was the occasion for me to figure out that some others code form Player class was concurrent with the PlayerStateMeditor?. I made some more code cleanup about it.

Will be embedded in 30 aug 2010 daily build / 1.9 RC7 / 1.9 final

I close this, feel free to reopen.

Add/Change #1704 (wrong systray text)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.