Modify

Opened 4 years ago

Last modified 20 months ago

#1649 new Task

"Use parent directory as album name" should not be enabled by default, and needs undo

Reported by: mats.ahlgren@… Owned by: bflorat
Priority: 3, low Milestone: To Be Decided by Jajuk Team
Component: Core Version: 1.9RC3
Keywords: engine Cc:
Regression ?:

Description

The option "Use parent directory as album name" should not be enabled by default, also needs either an undo or a prominent warning.

Reasoning: it is now impossible to search one's collection for songs one forgot to tag by album. Moreover, turning off the option does not "uncorrupt" the database. It is also impossible to tell from just the database if an album is actually tag-backed or logically-backed from the directory. This may be architecturally unsound.

Moreover, it might be the case that saving a song's Properties while this option is enabled might write an album name that wasn't intended to be written -- but I'm not sure.

One solution may be to mark albums in the database as "tag-backed" or "logically-backed", and when saving tags to never save "logically-backed" tags or if it *would* be the same as the folder name.

Attachments (0)

Change History (3)

comment:1 Changed 4 years ago by bflorat

  • Component changed from (Jajuk Members) Any (Default Component) to (Java Developer) Core
  • Milestone changed from To Be Qualified by Jajuk Team to 1.10 "Gute Laune"
  • Owner set to bflorat
  • Priority changed from 1, lowest to 3, low
  • Version set to 1.9RC3

To be discussed in Gute Laune

comment:2 Changed 4 years ago by bflorat

  • Milestone changed from 1.10 "Gute Laune" to To Be Decided by Jajuk Team
  • Type changed from Discussion to Task

Moreover, it might be the case that saving a song's Properties while this option is enabled might write an album name that wasn't intended to be written -- but I'm not sure.

No because we only actually change the tags for the fields changed in the Property dialog. If user doesn't change the album name in the GUI, it is not set into the tags.

  • The good thing with this is that what you call a "corruption" is not propagated into the tags themselves.
  • The bad thing is that the user cannot set the Album in tags because the value has to be changed.

I agree we should add something to discriminate album values from tags or from filesystem but I'm not sure that we should add a property to the album (among others reasons because it is a name attribute property, not an album property). Maybe should we store album names in a specific format like :name="T[MyAlbum?]" or "FS[MyAlbum?]" and parse it ?

comment:3 Changed 4 years ago by bflorat

  • Keywords engine added

Add Comment

Modify Ticket

Change Properties
Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.