"Use parent directory as album name" should not be enabled by default, and needs undo

[mats.ahlgren@…]

The option "Use parent directory as album name" should not be enabled by default, also needs either an undo or a prominent warning.

Reasoning: it is now impossible to search one's collection for songs one forgot to tag by album. Moreover, turning off the option does not "uncorrupt" the database. It is also impossible to tell from just the database if an album is actually tag-backed or logically-backed from the directory. This may be architecturally unsound.

Moreover, it might be the case that saving a song's Properties while this option is enabled might write an album name that wasn't intended to be written -- but I'm not sure.

One solution may be to mark albums in the database as "tag-backed" or "logically-backed", and when saving tags to never save "logically-backed" tags or if it *would* be the same as the folder name.

[bflorat]

To be discussed in Gute Laune

[bflorat]

Moreover, it might be the case that saving a song's Properties while this option is enabled might write an album name that wasn't intended to be written -- but I'm not sure.

No because we only actually change the tags for the fields changed in the Property dialog. If user doesn't change the album name in the GUI, it is not set into the tags.

• The good thing with this is that what you call a "corruption" is not propagated into the tags themselves.
• The bad thing is that the user cannot set the Album in tags because the value has to be changed.

I agree we should add something to discriminate album values from tags or from filesystem but I'm not sure that we should add a property to the album (among others reasons because it is a name attribute property, not an album property). Maybe should we store album names in a specific format like :name="T[MyAlbum?]" or "FS[MyAlbum?]" and parse it ?